-
Notifications
You must be signed in to change notification settings - Fork 67
chore: Update dependencies.txt to latest #4009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @blakeli0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine maintenance task: updating several key dependencies to their latest stable versions. This ensures the project benefits from the most recent features, bug fixes, and performance enhancements provided by these libraries, maintaining compatibility and security. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several dependencies in dependencies.txt. I've found a critical issue with the update to com.google.http-client:google-http-client. The new version 2.0.2 is a major version bump that is incompatible with com.google.api-client:google-api-client, which is also defined for testing in this file. This will likely break the build. I've left a comment with a suggestion to revert this specific change.
| io.grpc:grpc-bom,grpc=1.77.0 | ||
| com.google.auth:google-auth-library-bom,google.auth=1.41.0 | ||
| com.google.http-client:google-http-client,google.http-client=1.47.1 | ||
| com.google.http-client:google-http-client,google.http-client=2.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The major version update of google-http-client to 2.0.2 introduces a critical compatibility issue.
Another dependency defined in this file, com.google.api-client:google-api-client:2.8.1 (see line 28), requires a version of google-http-client within the range [1.42.0, 2.0.0). Version 2.0.2 is outside this range, which will likely cause build failures during compatibility testing.
To resolve this, please revert this dependency update.
com.google.http-client:google-http-client,google.http-client=1.47.1
|
/gcbrun |
|
|



Renovate bot has not been responsive due to rate limit. Manually updating the dependency versions to latest in upper bound test file dependencies.txt.
grpc-java 1.77.0 is not compatible. Created #4012 to track it.